Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Implement getOrdersAsync getOrdersForPageAsync for browsers #655

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Implement getOrdersAsync getOrdersForPageAsync for browsers #655

merged 4 commits into from
Jan 21, 2020

Conversation

albrow
Copy link
Contributor

@albrow albrow commented Jan 17, 2020 •
edited
Loading

Fixes #577. This PR adds both getOrdersAsync and getOrdersForPageAsync to the @0x/mesh-browser package.

@albrow albrow changed the base branch from feature/browser-get-stats to development January 18, 2020 00:06
@albrow albrow force-pushed the feature/browser-get-orders-for-page branch from 966a4d3 to 1404e84 Compare January 18, 2020 02:45
@albrow albrow changed the title Implement getOrdersForPageAsync for browsers Implement getOrdersAsync getOrdersForPageAsync for browsers Jan 18, 2020
@albrow albrow marked this pull request as ready for review January 18, 2020 03:00
jalextowle
jalextowle approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After reading this, I'm starting to wonder if we could autogenerate these Go wrappers (this code is very similar to the other implementations)

browser/ts/index.ts Show resolved Hide resolved
fabioberger
fabioberger approved these changes Jan 21, 2020
View reviewed changes
browser/ts/index.ts Show resolved Hide resolved
@albrow albrow merged commit ec65062 into development Jan 21, 2020
@albrow albrow deleted the feature/browser-get-orders-for-page branch January 21, 2020 20:44
@albrow albrow mentioned this pull request Jan 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@fabioberger fabioberger fabioberger approved these changes

Assignees

@albrow albrow

@fabioberger fabioberger

@jalextowle jalextowle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albrow @fabioberger @jalextowle